From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 1/5] Add a global synchronization point for pvclock Date: Tue, 26 Oct 2010 10:14:25 +0200 Message-ID: <4CC68DE1.1060604@redhat.com> References: <1271356648-5108-1-git-send-email-glommer@redhat.com> <1271356648-5108-2-git-send-email-glommer@redhat.com> <4CC6130B.8020908@goop.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Cc: Glauber Costa , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Marcelo Tosatti , Zachary Amsden , "Xen-devel@lists.xensource.com" To: Jeremy Fitzhardinge Return-path: In-Reply-To: <4CC6130B.8020908@goop.org> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 10/26/2010 01:30 AM, Jeremy Fitzhardinge wrote: > Unfortunately this is breaking Xen save/restore: if you restore on a > host which was booted more recently than the save host, causing the > system time to be smaller. The effect is that the domain's time leaps > forward to a fixed point, and stays there until the host catches up to > the source host... Shouldn't save/restore also save the timebase? > I guess last_time needs to be reset on this type of event. I guess the > cleanest way would be for pvclock.c to register a sysdev suspend/resume > handler. Should be for Xen only; kvm save/restore doesn't involve the guest. -- error compiling committee.c: too many arguments to function