From mboxrd@z Thu Jan  1 00:00:00 1970
From: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
Subject: Re: [PATCH v2 5/7] KVM: handle more completed apfs if possible
Date: Mon, 01 Nov 2010 17:34:50 +0800
Message-ID: <4CCE89BA.9090708@cn.fujitsu.com>
References: <4CCE8143.3090105@cn.fujitsu.com> <4CCE822B.1070909@cn.fujitsu.com> <20101101092457.GY26191@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Cc: Avi Kivity <avi@redhat.com>, Marcelo Tosatti <mtosatti@redhat.com>,
	LKML <linux-kernel@vger.kernel.org>, KVM <kvm@vger.kernel.org>
To: Gleb Natapov <gleb@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from cn.fujitsu.com ([222.73.24.84]:58668 "EHLO song.cn.fujitsu.com"
	rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP
	id S1752117Ab0KAJa0 (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 1 Nov 2010 05:30:26 -0400
In-Reply-To: <20101101092457.GY26191@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 11/01/2010 05:24 PM, Gleb Natapov wrote:

>> -		put_page(work->page);
>> -	kmem_cache_free(async_pf_cache, work);
>> +		list_del(&work->queue);
>> +		vcpu->async_pf.queued--;
>> +		if (work->page)
>> +			put_page(work->page);
>> +		kmem_cache_free(async_pf_cache, work);
>> +	} while (ret && !list_empty_careful(&vcpu->async_pf.done));
>>  }
>>  
> No need to change kvm_arch_async_page_present() to return anything. You
> can do while loop like this:
> 
> while (!list_empty_careful(&vcpu->async_pf.done) &&
>        kvm_arch_can_inject_async_page_present(vcpu)) {
> }
> 
> If kvm_arch_async_page_present() call injects exception
> kvm_arch_can_inject_async_page_present() will return false on next
> iteration.

Yeah, it's a better way, i'll fix it, thanks Gleb!