From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCHv2] trace "exit to userspace" event Date: Mon, 01 Nov 2010 17:19:40 -0400 Message-ID: <4CCF2EEC.2010901@redhat.com> References: <20101024144908.GF2343@redhat.com> <20101101160651.GC1429@amt.cnet> <4CCF1600.4010504@redhat.com> <20101101194356.GA8645@amt.cnet> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Gleb Natapov , kvm@vger.kernel.org To: Marcelo Tosatti Return-path: Received: from mx1.redhat.com ([209.132.183.28]:63043 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753054Ab0KAVT6 (ORCPT ); Mon, 1 Nov 2010 17:19:58 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id oA1LJwNR029838 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 1 Nov 2010 17:19:58 -0400 In-Reply-To: <20101101194356.GA8645@amt.cnet> Sender: kvm-owner@vger.kernel.org List-ID: On 11/01/2010 03:43 PM, Marcelo Tosatti wrote: > On Mon, Nov 01, 2010 at 03:33:20PM -0400, Avi Kivity wrote: > > On 11/01/2010 12:06 PM, Marcelo Tosatti wrote: > > >On Sun, Oct 24, 2010 at 04:49:08PM +0200, Gleb Natapov wrote: > > >> Add tracepoint for userspace exit. > > >> > > >> Signed-off-by: Gleb Natapov > > >> --- > > >> ChangeLog: > > >> v1->v2 > > >> log error case too. > > > > > >Applied, thanks. > > > > > > > errno sign is still flipped, no? > > No, kvm_arch_vcpu_ioctl_run return -errno on error. > It's true that this is how the kernel ABI is defined, but for a user errnos are positive. -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.