From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [PATCH 4/4] pci-assign: Remove broken -pcidevice and pci_add host Date: Wed, 03 Nov 2010 14:12:23 +0100 Message-ID: <4CD15FB7.5040601@siemens.com> References: <1dce616800caceaa2132daeb89ba1e703fd0115d.1288709734.git.jan.kiszka@siemens.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Avi Kivity , Marcelo Tosatti , "kvm@vger.kernel.org" , "Daniel P. Berrange" To: Markus Armbruster Return-path: Received: from goliath.siemens.de ([192.35.17.28]:16648 "EHLO goliath.siemens.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755238Ab0KCNMj (ORCPT ); Wed, 3 Nov 2010 09:12:39 -0400 In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: Am 03.11.2010 14:02, Markus Armbruster wrote: > Jan Kiszka writes: > >> These qemu-kvm-only interfaces were broken by b560a9ab9b, but no one >> complained loud enough to get them fixed again. As we have properly >> working "-device pci-assign"/"device_add" and we won't push this >> upstream anyway, there is likely no point in restoring the interface. > > Agree. Dan wrote re libvirt: > > As of libvirt >= 0.8.1 & QEMU >= 0.12.x we use switched to using > -device for everything. Older libvirt versions had rather broken > checking for PCI device topology, so I think it is fine to require > libvirt >= 0.8.1 for latest QEMU releases if users want PCI dev > assignment. Thus -pcidevice and pci_add can both be killed from our > POV. > > Note that this patch keeps pci_add nic|storage around. Unlikely to make > it upstream. pci_add is already in upstream. Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux