From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH -v2] Monitor command: pfa2hva, translate guest physical address to host virtual address Date: Sat, 06 Nov 2010 12:24:01 -0400 Message-ID: <4CD58121.2040209@redhat.com> References: <1288060789.2862.336.camel@yhuang-dev> <20101101160952.GE1429@amt.cnet> <4CCF0BAB.9000304@linux.vnet.ibm.com> <1288639205.2059.34.camel@yhuang-mobile> <4CCF136D.5080307@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Huang Ying , Marcelo Tosatti , Anthony Liguori , "kvm@vger.kernel.org" , Andi Kleen , Dean Nelson , Luiz Capitulino To: Anthony Liguori Return-path: Received: from mx1.redhat.com ([209.132.183.28]:26460 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754982Ab0KFQYN (ORCPT ); Sat, 6 Nov 2010 12:24:13 -0400 In-Reply-To: <4CCF136D.5080307@linux.vnet.ibm.com> Sender: kvm-owner@vger.kernel.org List-ID: On 11/01/2010 03:22 PM, Anthony Liguori wrote: > On 11/01/2010 02:20 PM, Huang Ying wrote: >> Yes. As general interface, it may not work so well, but as test >> interface, it works quite well and useful. >> >> Do we have any mechanism to add a test only interface? > > I'd like to see what Luiz/Markus think but definitely only a human > monitor interface and probably prefix the command with a 'x-' prefix > to indicate that it's not a supported interface. > Automated testing will want to use qmp. > The documentation should be very clear about the limitations of the > interface and the intended use-case. > Perhaps a { execute: 'enable-version-specific-commands', arguments: ['pfa2hva'] } ? -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.