From: Avi Kivity <avi@redhat.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>, kvm <kvm@vger.kernel.org>,
Alex Williamson <alex.williamson@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH v4 2/9] KVM: Switch IRQ subsystem to SRCU
Date: Tue, 09 Nov 2010 12:49:06 +0200 [thread overview]
Message-ID: <4CD92722.2060908@redhat.com> (raw)
In-Reply-To: <8cee16e41fc414c185e1d7c170ce44da19797fc1.1289215310.git.jan.kiszka@siemens.com>
On 11/08/2010 01:21 PM, Jan Kiszka wrote:
> Ack and mask notifiers typically call back into kvm_set_irq, thus may
> iterate over all VCPUs of a VM. Better keep this path preemptible to
> prevent that user-space can massivle influence scheduling latencies. Use
> sleepable RCU for the protection of irq_routing and the notfier lists.
>
What about preemptible RCU, now in mainline?
/*
* Tree-preemptable RCU implementation for rcu_read_lock().
* Just increment ->rcu_read_lock_nesting, shared state will be updated
* if we block.
*/
void __rcu_read_lock(void)
{
current->rcu_read_lock_nesting++;
barrier(); /* needed if we ever invoke rcu_read_lock in rcutree.c */
}
EXPORT_SYMBOL_GPL(__rcu_read_lock);
(wow, quite clever in its simplicity)
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2010-11-09 10:49 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-08 11:21 [PATCH v4 0/9] KVM: Improve IRQ assignment for device passthrough Jan Kiszka
2010-11-08 11:21 ` [PATCH v4 1/9] KVM: Fix srcu struct leakage Jan Kiszka
2010-11-08 17:00 ` Michael S. Tsirkin
2010-11-08 17:32 ` Jan Kiszka
2010-11-08 11:21 ` [PATCH v4 2/9] KVM: Switch IRQ subsystem to SRCU Jan Kiszka
2010-11-09 10:49 ` Avi Kivity [this message]
2010-11-09 11:21 ` Jan Kiszka
2010-11-08 11:21 ` [PATCH v4 3/9] KVM: Clear assigned guest IRQ on release Jan Kiszka
2010-11-09 10:58 ` Avi Kivity
2010-11-09 11:20 ` Jan Kiszka
2010-11-09 18:36 ` Alex Williamson
2010-11-10 6:53 ` Avi Kivity
2010-11-26 10:36 ` Michael S. Tsirkin
2010-11-08 11:21 ` [PATCH v4 4/9] KVM: Switch assigned device IRQ forwarding to threaded handler Jan Kiszka
2010-11-09 12:26 ` Avi Kivity
2010-11-09 12:36 ` Jan Kiszka
2010-11-08 11:21 ` [PATCH v4 5/9] KVM: Refactor IRQ names of assigned devices Jan Kiszka
2010-11-08 11:21 ` [PATCH v4 6/9] KVM: Save/restore state of assigned PCI device Jan Kiszka
2010-11-09 12:35 ` Avi Kivity
2010-11-09 13:29 ` Jan Kiszka
2010-11-09 13:36 ` Avi Kivity
2010-11-09 13:44 ` Jan Kiszka
2010-11-09 13:46 ` Avi Kivity
2010-11-09 16:41 ` Don Dutile
2010-11-08 11:21 ` [PATCH v4 7/9] KVM: Clean up kvm_vm_ioctl_assigned_device Jan Kiszka
2010-11-08 11:21 ` [PATCH v4 8/9] KVM: Document device assigment API Jan Kiszka
2010-11-08 11:21 ` [PATCH v4 9/9] KVM: Allow host IRQ sharing for passed-through PCI 2.3 devices Jan Kiszka
2010-11-09 13:27 ` Avi Kivity
2010-11-09 13:35 ` Jan Kiszka
2010-11-09 13:41 ` Avi Kivity
2010-11-09 14:11 ` Jan Kiszka
2010-11-09 14:20 ` Avi Kivity
2010-11-16 16:55 ` [PATCH v4 0/9] KVM: Improve IRQ assignment for device passthrough Marcelo Tosatti
2010-11-16 18:26 ` Jan Kiszka
2010-11-17 8:25 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CD92722.2060908@redhat.com \
--to=avi@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=kvm@vger.kernel.org \
--cc=mst@redhat.com \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox