From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@redhat.com>
Subject: Re: [PATCH] KVM: Fix srcu struct leakage
Date: Tue, 09 Nov 2010 16:00:00 +0200
Message-ID: <4CD953E0.70809@redhat.com>
References: <4CD93366.5000209@siemens.com> <20101109135350.GA25952@amt.cnet>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Jan Kiszka <jan.kiszka@siemens.com>, kvm <kvm@vger.kernel.org>
To: Marcelo Tosatti <mtosatti@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:2109 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752019Ab0KIOAG (ORCPT <rfc822;kvm@vger.kernel.org>);
	Tue, 9 Nov 2010 09:00:06 -0500
In-Reply-To: <20101109135350.GA25952@amt.cnet>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 11/09/2010 03:53 PM, Marcelo Tosatti wrote:
> On Tue, Nov 09, 2010 at 12:41:26PM +0100, Jan Kiszka wrote:
> >  Clean up the srcu struct on vm destruction.
> >
> >  Signed-off-by: Jan Kiszka<jan.kiszka@siemens.com>
> >  ---
> >   virt/kvm/kvm_main.c |    1 +
> >   1 files changed, 1 insertions(+), 0 deletions(-)
> >
> >  diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
> >  index 4111a4b..6ec58d1 100644
> >  --- a/virt/kvm/kvm_main.c
> >  +++ b/virt/kvm/kvm_main.c
> >  @@ -513,6 +513,7 @@ static void kvm_destroy_vm(struct kvm *kvm)
> >   #else
> >   	kvm_arch_flush_shadow(kvm);
> >   #endif
> >  +	cleanup_srcu_struct(&kvm->srcu);
> >   	kvm_arch_destroy_vm(kvm);
> >   	hardware_disable_all();
> >   	mmdrop(mm);
> >  -- 
> >  1.7.1
>
> kvm_arch_destroy_vm does it.

True.  Dropped.

-- 
error compiling committee.c: too many arguments to function