* [PATCH 1/1] virt: ack_flush() function removed for lack of apparent use 2.6.37-rc1
@ 2010-11-06 5:01 André Luis Pereira dos Santos - BSRSoft
2010-11-09 14:32 ` Avi Kivity
0 siblings, 1 reply; 2+ messages in thread
From: André Luis Pereira dos Santos - BSRSoft @ 2010-11-06 5:01 UTC (permalink / raw)
To: Avi Kivity; +Cc: Marcelo Tosatti, kvm, linux-kernel
Hello
Ack_flush function () is not used anywhere in the code and apparently has no function currently defined.
Unless there are plans to use it in the future, I took it out via this patch code for readability.
Signed-off-by: Andre Luis Pereira dos Santos <andre@bsrsoft.com.br>
---
Signed-off-by: Andre Luis Pereira dos Santos <andre@bsrsoft.com.br>
--- linux-2.6.37-rc1/virt/kvm/kvm_main.c 2010-11-01 09:54:12.000000000 -0200
+++ linux-2.6.37-rc1-patched/virt/kvm/kvm_main.c 2010-11-06 02:43:56.000000000 -0200
@@ -132,9 +132,6 @@ void vcpu_put(struct kvm_vcpu *vcpu)
mutex_unlock(&vcpu->mutex);
}
-static void ack_flush(void *_completed)
-{
-}
static bool make_all_cpus_request(struct kvm *kvm, unsigned int req)
{
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] virt: ack_flush() function removed for lack of apparent use 2.6.37-rc1
2010-11-06 5:01 [PATCH 1/1] virt: ack_flush() function removed for lack of apparent use 2.6.37-rc1 André Luis Pereira dos Santos - BSRSoft
@ 2010-11-09 14:32 ` Avi Kivity
0 siblings, 0 replies; 2+ messages in thread
From: Avi Kivity @ 2010-11-09 14:32 UTC (permalink / raw)
To: andre; +Cc: Marcelo Tosatti, kvm, linux-kernel
On 11/06/2010 07:01 AM, André Luis Pereira dos Santos - BSRSoft wrote:
> Hello
>
> Ack_flush function () is not used anywhere in the code and apparently has no function currently defined.
>
> Unless there are plans to use it in the future, I took it out via this patch code for readability.
>
>
>
> Signed-off-by: Andre Luis Pereira dos Santos<andre@bsrsoft.com.br>
> ---
> Signed-off-by: Andre Luis Pereira dos Santos<andre@bsrsoft.com.br>
> --- linux-2.6.37-rc1/virt/kvm/kvm_main.c 2010-11-01 09:54:12.000000000 -0200
> +++ linux-2.6.37-rc1-patched/virt/kvm/kvm_main.c 2010-11-06 02:43:56.000000000 -0200
> @@ -132,9 +132,6 @@ void vcpu_put(struct kvm_vcpu *vcpu)
> mutex_unlock(&vcpu->mutex);
> }
>
> -static void ack_flush(void *_completed)
> -{
> -}
>
It is in use:
> upstream:virt/kvm/kvm_main.c:static void ack_flush(void *_completed)
> upstream:virt/kvm/kvm_main.c:
> smp_call_function_many(cpu_online_mask, ack_flush, NULL, 1);
> upstream:virt/kvm/kvm_main.c: smp_call_function_many(cpus,
> ack_flush, NULL, 1);
--
error compiling committee.c: too many arguments to function
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-11-09 14:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-11-06 5:01 [PATCH 1/1] virt: ack_flush() function removed for lack of apparent use 2.6.37-rc1 André Luis Pereira dos Santos - BSRSoft
2010-11-09 14:32 ` Avi Kivity
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox