From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 1/1] virt: ack_flush() function removed for lack of apparent use 2.6.37-rc1 Date: Tue, 09 Nov 2010 16:32:51 +0200 Message-ID: <4CD95B93.70607@redhat.com> References: <516164.25539.qm@web110514.mail.gq1.yahoo.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Marcelo Tosatti , kvm@vger.kernel.org, linux-kernel@vger.kernel.org To: andre@bsrsoft.com.br Return-path: Received: from mx1.redhat.com ([209.132.183.28]:36020 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751089Ab0KIOc4 (ORCPT ); Tue, 9 Nov 2010 09:32:56 -0500 In-Reply-To: <516164.25539.qm@web110514.mail.gq1.yahoo.com> Sender: kvm-owner@vger.kernel.org List-ID: On 11/06/2010 07:01 AM, Andr=E9 Luis Pereira dos Santos - BSRSoft wrote= : > Hello > > Ack_flush function () is not used anywhere in the code and apparently= has no function currently defined. > > Unless there are plans to use it in the future, I took it out via thi= s patch code for readability. > > > > Signed-off-by: Andre Luis Pereira dos Santos > --- > Signed-off-by: Andre Luis Pereira dos Santos > --- linux-2.6.37-rc1/virt/kvm/kvm_main.c 2010-11-01 09:54:12.00000000= 0 -0200 > +++ linux-2.6.37-rc1-patched/virt/kvm/kvm_main.c 2010-11-06 02:43:56.= 000000000 -0200 > @@ -132,9 +132,6 @@ void vcpu_put(struct kvm_vcpu *vcpu) > mutex_unlock(&vcpu->mutex); > } > > -static void ack_flush(void *_completed) > -{ > -} > It is in use: > upstream:virt/kvm/kvm_main.c:static void ack_flush(void *_completed) > upstream:virt/kvm/kvm_main.c: =20 > smp_call_function_many(cpu_online_mask, ack_flush, NULL, 1); > upstream:virt/kvm/kvm_main.c: smp_call_function_many(cpus,=20 > ack_flush, NULL, 1); --=20 error compiling committee.c: too many arguments to function