From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christian Borntraeger <borntraeger-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH] KVM: Clean up vm creation and release
Date: Tue, 09 Nov 2010 16:42:37 +0100
Message-ID: <4CD96BED.5080504@de.ibm.com>
References: <4CD96195.2000708@siemens.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Cc: Avi Kivity <avi-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>, Marcelo Tosatti <mtosatti-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	kvm <kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, kvm-ppc <kvm-ppc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"kvm-ia64-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" <kvm-ia64-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Alexander Graf <agraf-l3A5Bk7waGM@public.gmane.org>,
	"Zhang, Xiantao" <xiantao.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	Carsten Otte <cotte-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org>, linux-s390-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
To: Jan Kiszka <jan.kiszka-kv7WeFo6aLtBDgjK7y7TUQ@public.gmane.org>
Return-path: <kvm-ppc-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
In-Reply-To: <4CD96195.2000708-kv7WeFo6aLtBDgjK7y7TUQ@public.gmane.org>
Sender: kvm-ppc-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
List-Id: kvm.vger.kernel.org

> diff --git a/arch/s390/kvm/kvm-s390.c b/arch/s390/kvm/kvm-s390.c
> index 985d825..d8d1877 100644
> --- a/arch/s390/kvm/kvm-s390.c
> +++ b/arch/s390/kvm/kvm-s390.c
> @@ -164,24 +164,18 @@ long kvm_arch_vm_ioctl(struct file *filp,
>  	return r;
>  }
> 
> -struct kvm *kvm_arch_create_vm(void)
> +int kvm_arch_create_vm(struct kvm *kvm)

needs to be renamed to
       kvm_arch_init_vm

[...]

> --- a/include/linux/kvm_host.h
> +++ b/include/linux/kvm_host.h
> @@ -441,7 +441,19 @@ int kvm_arch_vcpu_runnable(struct kvm_vcpu *vcpu);
> 
>  void kvm_free_physmem(struct kvm *kvm);
> 
> -struct  kvm *kvm_arch_create_vm(void);
> +#ifndef __KVM_HAVE_ARCH_VM_ALLOC
> +static inline struct kvm *kvm_arch_alloc_vm(void)
> +{
> +	return kzalloc(sizeof(struct kvm), GFP_KERNEL);

I have not checked kvm.git but on Linux head we need
#include <linux/slab.h>
for kzalloc.

Christian