From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gerd Hoffmann Subject: Re: [PATCHv3 08/14] Add get_fw_dev_path callback for pci bus. Date: Thu, 11 Nov 2010 11:07:01 +0100 Message-ID: <4CDBC045.3070902@redhat.com> References: <1289409261-5418-1-git-send-email-gleb@redhat.com> <1289409261-5418-9-git-send-email-gleb@redhat.com> <20101110173412.GE3891@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Gleb Natapov , qemu-devel@nongnu.org, kvm@vger.kernel.org, blauwirbel@gmail.com, armbru@redhat.com, alex.williamson@redhat.com To: "Michael S. Tsirkin" Return-path: Received: from mx1.redhat.com ([209.132.183.28]:61205 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754345Ab0KKKHJ (ORCPT ); Thu, 11 Nov 2010 05:07:09 -0500 In-Reply-To: <20101110173412.GE3891@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 11/10/10 18:34, Michael S. Tsirkin wrote: > On Wed, Nov 10, 2010 at 07:14:15PM +0200, Gleb Natapov wrote: >> >> Signed-off-by: Gleb Natapov > > Good stuff. We should also consider using this for > CLI and monitor. Some comments below. Oh, we already have a table to map pci classes to descriptions for 'info pci'. I'd strongly suggest to just add the fw names to that table instead of creating a second one ... cheers, Gerd