From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [PATCH] intel-iommu: Fix use after release during device attach Date: Sun, 14 Nov 2010 10:18:37 +0100 Message-ID: <4CDFA96D.1060301@web.de> References: <4CCFB84F.6050102@web.de> <201011021531.22886.sheng@linux.intel.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig5B18957E2AC8B8658A10647B" Cc: Linux Kernel Mailing List , kvm , Avi Kivity , Marcelo Tosatti , iommu@lists.linux-foundation.org To: Sheng Yang , David Woodhouse Return-path: In-Reply-To: <201011021531.22886.sheng@linux.intel.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig5B18957E2AC8B8658A10647B Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Am 02.11.2010 08:31, Sheng Yang wrote: > On Tuesday 02 November 2010 15:05:51 Jan Kiszka wrote: >> From: Jan Kiszka >> >> Obtail the new pgd pointer before releasing the page containing this >> value. >> >> Signed-off-by: Jan Kiszka >> --- >> >> Who is taking care of this? The kvm tree? >> >> drivers/pci/intel-iommu.c | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/drivers/pci/intel-iommu.c b/drivers/pci/intel-iommu.c >> index 4789f8e..35463dd 100644 >> --- a/drivers/pci/intel-iommu.c >> +++ b/drivers/pci/intel-iommu.c >> @@ -3627,9 +3627,9 @@ static int intel_iommu_attach_device(struct >> iommu_domain *domain, >> >> pte =3D dmar_domain->pgd; >> if (dma_pte_present(pte)) { >> - free_pgtable_page(dmar_domain->pgd); >> dmar_domain->pgd =3D (struct dma_pte *) >> phys_to_virt(dma_pte_addr(pte)); >> + free_pgtable_page(pte); >> } >> dmar_domain->agaw--; >> } >=20 > Reviewed-by: Sheng Yang >=20 > CC iommu mailing list and David. Ping... I think this fix also qualifies for stable (.35 and .36). Jan --------------enig5B18957E2AC8B8658A10647B Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.15 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org/ iEYEARECAAYFAkzfqXQACgkQitSsb3rl5xQ0nwCgwqR+xLqadCpFKJq9IutkdEaG hh0AniOLfRH8w3Uy94fnT8VT+OE+Xpem =gI8i -----END PGP SIGNATURE----- --------------enig5B18957E2AC8B8658A10647B--