From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] KVM: VMX: Inform user about INTEL_TXT dependency Date: Sun, 14 Nov 2010 12:30:27 +0200 Message-ID: <4CDFBA43.60808@redhat.com> References: <4CDFA967.7000508@web.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , kvm , Shane Wang To: Jan Kiszka Return-path: Received: from mx1.redhat.com ([209.132.183.28]:55885 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754659Ab0KNKac (ORCPT ); Sun, 14 Nov 2010 05:30:32 -0500 In-Reply-To: <4CDFA967.7000508@web.de> Sender: kvm-owner@vger.kernel.org List-ID: On 11/14/2010 11:18 AM, Jan Kiszka wrote: > From: Jan Kiszka > > Without CONFIG_INTEL_TXT, the user must not enable this feature in the > BIOS. Otherwise, KVM will not work. Explain this dependency via a kernel > log message. > > Signed-off-by: Jan Kiszka > --- > arch/x86/kvm/vmx.c | 7 ++++++- > 1 files changed, 6 insertions(+), 1 deletions(-) > > diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c > index 9367abc..ebafd57 100644 > --- a/arch/x86/kvm/vmx.c > +++ b/arch/x86/kvm/vmx.c > @@ -1306,8 +1306,13 @@ static __init int vmx_disabled_by_bios(void) > && tboot_enabled()) > return 1; > if (!(msr& FEATURE_CONTROL_VMXON_ENABLED_OUTSIDE_SMX) > - && !tboot_enabled()) > + && !tboot_enabled()) { > +#ifndef CONFIG_INTEL_TXT > + printk(KERN_INFO "kvm: if TXT is enabled in the bios, " > + "kvm depends on CONFIG_INTEL_TXT\n"); > +#endif > return 1; > + } > } > Maybe reword to an instruction? Something like kvm: TXT enabled in the bios. Either disable TXT in the bios, or enable CONFIG_INTEL_TXT in your kernel. -- error compiling committee.c: too many arguments to function