RE: [PATCH]KVM: VMX: Inform user about INTEL_TXT dependency

Wang, Shane
2010-11-18T00:36:28Z

After discussing with Joe, we gave it up (i.e. not depend on enabled-inside-smx;)

Thanks.
Shane

-----Original Message-----
From: Jan Kiszka [mailto:jan.kiszka@siemens.com]
Sent: 2010年11月17日 15:56
To: Wang, Shane
Cc: avi@redhat.com; mtosatti@redhat.com; kvm@vger.kernel.org; Cihula, Joseph
Subject: Re: [PATCH]KVM: VMX: Inform user about INTEL_TXT dependency

Am 17.11.2010 04:40, Shane Wang wrote:
> Inform user to either disable TXT in the BIOS or do TXT launch with tboot before enabling KVM since some BIOSes do not set FEATURE_CONTROL_VMXON_ENABLED_OUTSIDE_SMX bit when TXT is enabled.
>
> Signed-off-by: Shane Wang <shane.wang@intel.com>
> ---
> arch/x86/kvm/vmx.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff -r b1a2deff4c64 arch/x86/kvm/vmx.c
> --- a/arch/x86/kvm/vmx.c Wed Nov 17 12:47:42 2010 -0500
> +++ b/arch/x86/kvm/vmx.c Wed Nov 17 12:49:52 2010 -0500
> @@ -1306,8 +1306,11 @@
> && tboot_enabled())
> return 1;
> if (!(msr & FEATURE_CONTROL_VMXON_ENABLED_OUTSIDE_SMX)
> - && !tboot_enabled())
> + && !tboot_enabled()) {
> + printk(KERN_WARNING "kvm: disable TXT in the BIOS or "
> + " activate TXT before enabling KVM\n");

Thought you wanted to let this message depend on ENABLED_INSIDE_SMX?
However, if it's OK for you, I'm fine with it as well.

Thanks!
Jan

> return 1;
> + }
> }
>
> return 0;

--
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux