From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH v2 5/5] KVM: MMU: retry #PF for softmmu Date: Sun, 14 Nov 2010 12:46:24 +0200 Message-ID: <4CDFBE00.2000802@redhat.com> References: <4CDCE2B0.7000601@cn.fujitsu.com> <4CDCE3C2.9030107@cn.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , Gleb Natapov , LKML , KVM To: Xiao Guangrong Return-path: In-Reply-To: <4CDCE3C2.9030107@cn.fujitsu.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 11/12/2010 08:50 AM, Xiao Guangrong wrote: > Retry #PF for softmmu only when the current vcpu has the same > root shadow page as the time when #PF occurs. it means they > have same paging environment > The process could have been killed and replaced by another using the same cr3. Or we may be running a guest that uses the same cr3 for all processes. Or another thread may have mmap()ed something else over the same address. So I think this is incorrect. Meanwhile, I applied patches 1-4. -- error compiling committee.c: too many arguments to function