From mboxrd@z Thu Jan 1 00:00:00 1970 From: Xiao Guangrong Subject: Re: [PATCH 1/4] KVM: MMU: don't drop spte if overwrite it from W to RO Date: Mon, 15 Nov 2010 13:34:24 +0800 Message-ID: <4CE0C660.5000109@cn.fujitsu.com> References: <4CDD173E.8010706@cn.fujitsu.com> <4CDFBF5B.10706@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , LKML , KVM To: Avi Kivity Return-path: In-Reply-To: <4CDFBF5B.10706@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 11/14/2010 06:52 PM, Avi Kivity wrote: > On 11/12/2010 12:30 PM, Xiao Guangrong wrote: >> We just need flush tlb if overwrite a writable spte with a read-only one >> > > What are the advantages? Avoid playing with rmap, and avoid a window > where the spte is missing? > Both, but only the first was in my mind when i'm making the patch :-)