From mboxrd@z Thu Jan 1 00:00:00 1970 From: Xiao Guangrong Subject: Re: [PATCH 3/4] KVM: MMU: notrap it if gpte's reserved is set Date: Mon, 15 Nov 2010 13:41:04 +0800 Message-ID: <4CE0C7F0.2040407@cn.fujitsu.com> References: <4CDD173E.8010706@cn.fujitsu.com> <4CDD1841.9010300@cn.fujitsu.com> <4CDFC04A.8010907@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , LKML , KVM To: Avi Kivity Return-path: In-Reply-To: <4CDFC04A.8010907@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 11/14/2010 06:56 PM, Avi Kivity wrote: > On 11/12/2010 12:34 PM, Xiao Guangrong wrote: >> We can past the page fault to guest directly if gpte's reserved >> is set >> > > How can that work? shadow_notrap_nonpresent_pte causes a fault with > PFEC.P=PFEC.RSVD=0, while we need PFEC.P=PFEC.RSVD=1. > Ah, i missed it for a long time, thanks for you point it out. The same mistake is in 'prefetch' path, i'll fix it in the v2 version.