From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [RFC][PATCH] qemu-kvm: Drop vga dirty logging workarounds Date: Mon, 15 Nov 2010 15:16:34 +0200 Message-ID: <4CE132B2.9050507@redhat.com> References: <4CE10C55.5040104@siemens.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , kvm To: Jan Kiszka Return-path: Received: from mx1.redhat.com ([209.132.183.28]:48444 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755766Ab0KONQk (ORCPT ); Mon, 15 Nov 2010 08:16:40 -0500 In-Reply-To: <4CE10C55.5040104@siemens.com> Sender: kvm-owner@vger.kernel.org List-ID: On 11/15/2010 12:32 PM, Jan Kiszka wrote: > These diffs to upstream should all date back to the days qemu-kvm > supported vga dirty logging with restricted/broken kvm kernel modules. > We no longer do, so there is no need for those workarounds. Even worse > they can trigger internal bug checks these days: > > BUG: kvm_dirty_pages_log_change: invalid parameters 00000000000a8000-00000000000affff I'd like to apply this. What kind of testing has this seen? autotest likely isn't a good enough test. -- error compiling committee.c: too many arguments to function