From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: seabios 0.6.1 regression Date: Mon, 15 Nov 2010 17:12:23 +0200 Message-ID: <4CE14DD7.4040102@redhat.com> References: <4CE13815.90902@redhat.com> <4CE14BFB.7070306@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit To: "Kevin O'Connor" , "seabios@seabios.org" , KVM list Return-path: Received: from mx1.redhat.com ([209.132.183.28]:65029 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755882Ab0KOPMl (ORCPT ); Mon, 15 Nov 2010 10:12:41 -0500 In-Reply-To: <4CE14BFB.7070306@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 11/15/2010 05:04 PM, Avi Kivity wrote: > On 11/15/2010 03:39 PM, Avi Kivity wrote: >> Installing Windows XP with seabios 0.6.1, immediately after the first >> reboot, Windows hangs in protected mode instead of proceeding with >> installation. >> >> I'm bisecting this, but if anyone can point to a likely culprit, I >> can try it first. >> > > Bisect says: > > commit 9a01a9c3eb336eca37c17fd74c79806ee0bda05b > Author: Kevin O'Connor > Date: Wed Aug 25 21:07:48 2010 -0400 > > Only show bootsplash during boot menu. > > When the bootsplash picture is shown, it's not possible to see text. > So, only display the picture while prompting the user for the boot > menu. > > git bisect start 'rel-0.6.1' '17d3e46511aeedc9f09a8216d194d749187b80aa' > # good: [b4525a0ec176426788f293cce92160e6573e86b6] Handle unaligned > sizes in iomemcpy(). > git bisect good b4525a0ec176426788f293cce92160e6573e86b6 > # good: [e2074bf6ec2956e1d803e62dcb052b7c88c214f0] Add ACPI SSDT/DSDT > support for CPU hotplug. > git bisect good e2074bf6ec2956e1d803e62dcb052b7c88c214f0 > # bad: [7ce09ae6542f0f4187024ae3267b61a0cf6ebd39] Make > tools/transdump.py more resilient to unknown input. > git bisect bad 7ce09ae6542f0f4187024ae3267b61a0cf6ebd39 > # good: [5feb83c8a55744397b4dd208fb4016a5c051222e] add write support > to virtio-blk > git bisect good 5feb83c8a55744397b4dd208fb4016a5c051222e > # bad: [6039fc55274deb7202060d08e0f23b9f3dcface4] Update qemu_cfg_read > to use "rep insb". > git bisect bad 6039fc55274deb7202060d08e0f23b9f3dcface4 > > That was premature, the real culprit (if I didn't mess up the bisect) is: commit 6039fc55274deb7202060d08e0f23b9f3dcface4 Author: Kevin O'Connor Date: Wed Aug 25 21:43:19 2010 -0400 Update qemu_cfg_read to use "rep insb". Use rep insb instead of manual loop - the host may be able to optimize the rep insb instruction. Which doesn't make any sense - will do more testing. -- error compiling committee.c: too many arguments to function