Re: seabios 0.6.1 regression

[Avi Kivity <avi@redhat.com>]

On 11/15/2010 05:34 PM, Avi Kivity wrote:
> On 11/15/2010 05:12 PM, Avi Kivity wrote:
>>
>> That was premature, the real culprit (if I didn't mess up the bisect) 
>> is:
>>
>> commit 6039fc55274deb7202060d08e0f23b9f3dcface4
>> Author: Kevin O'Connor <kevin@koconnor.net>
>> Date:   Wed Aug 25 21:43:19 2010 -0400
>>
>>     Update qemu_cfg_read to use "rep insb".
>>
>>     Use rep insb instead of manual loop - the host may be able to 
>> optimize
>>     the rep insb instruction.
>>
>> Which doesn't make any sense - will do more testing.
>>
>
> Confirmed with multiple tests.
>

I think it's a miscompile.

out/code16.o:
  1a4:   3e                      ds
  1a5:   6c                      insb   (%dx),%es:(%edi)

Note no 66 prefix.

-- 
error compiling committee.c: too many arguments to function