From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: seabios 0.6.1 regression Date: Mon, 15 Nov 2010 17:41:07 +0200 Message-ID: <4CE15493.7070907@redhat.com> References: <4CE13815.90902@redhat.com> <4CE14BFB.7070306@redhat.com> <4CE14DD7.4040102@redhat.com> <4CE15307.40801@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit To: "Kevin O'Connor" , "seabios@seabios.org" , KVM list Return-path: Received: from mx1.redhat.com ([209.132.183.28]:50565 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754421Ab0KOPlX (ORCPT ); Mon, 15 Nov 2010 10:41:23 -0500 In-Reply-To: <4CE15307.40801@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 11/15/2010 05:34 PM, Avi Kivity wrote: > On 11/15/2010 05:12 PM, Avi Kivity wrote: >> >> That was premature, the real culprit (if I didn't mess up the bisect) >> is: >> >> commit 6039fc55274deb7202060d08e0f23b9f3dcface4 >> Author: Kevin O'Connor >> Date: Wed Aug 25 21:43:19 2010 -0400 >> >> Update qemu_cfg_read to use "rep insb". >> >> Use rep insb instead of manual loop - the host may be able to >> optimize >> the rep insb instruction. >> >> Which doesn't make any sense - will do more testing. >> > > Confirmed with multiple tests. > I think it's a miscompile. out/code16.o: 1a4: 3e ds 1a5: 6c insb (%dx),%es:(%edi) Note no 66 prefix. -- error compiling committee.c: too many arguments to function