public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: "Kevin O'Connor" <kevin@koconnor.net>
Cc: "seabios@seabios.org" <seabios@seabios.org>,
	KVM list <kvm@vger.kernel.org>
Subject: Re: seabios 0.6.1 regression
Date: Tue, 16 Nov 2010 11:05:53 +0200	[thread overview]
Message-ID: <4CE24971.6030000@redhat.com> (raw)
In-Reply-To: <20101116001859.GA28639@morn.localdomain>

On 11/16/2010 02:18 AM, Kevin O'Connor wrote:
> >
> >  Rewriting it to use inb / stos works (jecxz ; insb; loop doesn't) so
> >  it looks like a kernel bug in insb emulation.
>
> Ughh.  I can revert that change on stable-0.6.1 if needed.

kernel bug -> kernel fix.  SeaBIOS should feel free to use any 
documented hardware capability, esp. something as basic as rep insb 
which dates back to the good old 8086 days.

As an exception I ask that you stay away from big real mode and SMM.

> It sounds
> like we really do want this on the main branch though for the speed
> benefit it provides.

Yes.

-- 
error compiling committee.c: too many arguments to function


  reply	other threads:[~2010-11-16  9:06 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-15 13:39 seabios 0.6.1 regression Avi Kivity
2010-11-15 15:04 ` Avi Kivity
2010-11-15 15:12   ` Avi Kivity
2010-11-15 15:34     ` Avi Kivity
2010-11-15 15:41       ` Avi Kivity
2010-11-15 15:49         ` Avi Kivity
2010-11-15 16:09           ` Avi Kivity
2010-11-16  0:18             ` Kevin O'Connor
2010-11-16  9:05               ` Avi Kivity [this message]
2010-11-16 10:47             ` Avi Kivity
2010-11-16 13:19               ` Alexander Graf
2010-11-16 14:15                 ` Avi Kivity
2010-11-16 14:17                   ` Alexander Graf
2010-11-16 14:27                     ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CE24971.6030000@redhat.com \
    --to=avi@redhat.com \
    --cc=kevin@koconnor.net \
    --cc=kvm@vger.kernel.org \
    --cc=seabios@seabios.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox