From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: seabios 0.6.1 regression Date: Tue, 16 Nov 2010 11:05:53 +0200 Message-ID: <4CE24971.6030000@redhat.com> References: <4CE13815.90902@redhat.com> <4CE14BFB.7070306@redhat.com> <4CE14DD7.4040102@redhat.com> <4CE15307.40801@redhat.com> <4CE15493.7070907@redhat.com> <4CE1568B.1090207@redhat.com> <4CE15B49.4000509@redhat.com> <20101116001859.GA28639@morn.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: "seabios@seabios.org" , KVM list To: "Kevin O'Connor" Return-path: Received: from mx1.redhat.com ([209.132.183.28]:64965 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932434Ab0KPJGO (ORCPT ); Tue, 16 Nov 2010 04:06:14 -0500 In-Reply-To: <20101116001859.GA28639@morn.localdomain> Sender: kvm-owner@vger.kernel.org List-ID: On 11/16/2010 02:18 AM, Kevin O'Connor wrote: > > > > Rewriting it to use inb / stos works (jecxz ; insb; loop doesn't) so > > it looks like a kernel bug in insb emulation. > > Ughh. I can revert that change on stable-0.6.1 if needed. kernel bug -> kernel fix. SeaBIOS should feel free to use any documented hardware capability, esp. something as basic as rep insb which dates back to the good old 8086 days. As an exception I ask that you stay away from big real mode and SMM. > It sounds > like we really do want this on the main branch though for the speed > benefit it provides. Yes. -- error compiling committee.c: too many arguments to function