From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [PATCH]KVM: VMX: Inform user about INTEL_TXT dependency Date: Wed, 17 Nov 2010 08:56:27 +0100 Message-ID: <4CE38AAB.4090906@siemens.com> References: <1289965217-14270-1-git-send-email-shane.wang@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: "avi@redhat.com" , "mtosatti@redhat.com" , "kvm@vger.kernel.org" , "joseph.cihula@intel.com" To: Shane Wang Return-path: Received: from david.siemens.de ([192.35.17.14]:20154 "EHLO david.siemens.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753757Ab0KQH4t (ORCPT ); Wed, 17 Nov 2010 02:56:49 -0500 In-Reply-To: <1289965217-14270-1-git-send-email-shane.wang@intel.com> Sender: kvm-owner@vger.kernel.org List-ID: Am 17.11.2010 04:40, Shane Wang wrote: > Inform user to either disable TXT in the BIOS or do TXT launch with tboot before enabling KVM since some BIOSes do not set FEATURE_CONTROL_VMXON_ENABLED_OUTSIDE_SMX bit when TXT is enabled. > > Signed-off-by: Shane Wang > --- > arch/x86/kvm/vmx.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff -r b1a2deff4c64 arch/x86/kvm/vmx.c > --- a/arch/x86/kvm/vmx.c Wed Nov 17 12:47:42 2010 -0500 > +++ b/arch/x86/kvm/vmx.c Wed Nov 17 12:49:52 2010 -0500 > @@ -1306,8 +1306,11 @@ > && tboot_enabled()) > return 1; > if (!(msr & FEATURE_CONTROL_VMXON_ENABLED_OUTSIDE_SMX) > - && !tboot_enabled()) > + && !tboot_enabled()) { > + printk(KERN_WARNING "kvm: disable TXT in the BIOS or " > + " activate TXT before enabling KVM\n"); Thought you wanted to let this message depend on ENABLED_INSIDE_SMX? However, if it's OK for you, I'm fine with it as well. Thanks! Jan > return 1; > + } > } > > return 0; -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux