From mboxrd@z Thu Jan 1 00:00:00 1970 From: Xiao Guangrong Subject: Re: [PATCH v2 1/6] KVM: MMU: fix forgot flush vcpu tlbs Date: Thu, 18 Nov 2010 15:17:26 +0800 Message-ID: <4CE4D306.6030707@cn.fujitsu.com> References: <4CE355A0.6020907@cn.fujitsu.com> <20101117152943.GA18959@amt.cnet> <4CE4024B.4090600@redhat.com> <20101117173616.GG18959@amt.cnet> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: Avi Kivity , LKML , KVM To: Marcelo Tosatti Return-path: In-Reply-To: <20101117173616.GG18959@amt.cnet> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 11/18/2010 01:36 AM, Marcelo Tosatti wrote: >> I don't think we need to flush immediately; set a "tlb dirty" bit >> somewhere that is cleareded when we flush the tlb. >> kvm_mmu_notifier_invalidate_page() can consult the bit and force a >> flush if set. > > Yep. > Great, i'll do it in the v3. Do we need a simple bug fix patch(which immediately flush tlbs) for backport first?