From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@redhat.com>
Subject: Re: [PATCH v2 1/6] KVM: MMU: fix forgot flush vcpu tlbs
Date: Thu, 18 Nov 2010 11:32:02 +0200
Message-ID: <4CE4F292.2060608@redhat.com>
References: <4CE355A0.6020907@cn.fujitsu.com> <20101117152943.GA18959@amt.cnet> <4CE4024B.4090600@redhat.com> <20101117173616.GG18959@amt.cnet> <4CE4D306.6030707@cn.fujitsu.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
	LKML <linux-kernel@vger.kernel.org>, KVM <kvm@vger.kernel.org>
To: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:49771 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751769Ab0KRJcI (ORCPT <rfc822;kvm@vger.kernel.org>);
	Thu, 18 Nov 2010 04:32:08 -0500
In-Reply-To: <4CE4D306.6030707@cn.fujitsu.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 11/18/2010 09:17 AM, Xiao Guangrong wrote:
> On 11/18/2010 01:36 AM, Marcelo Tosatti wrote:
>
> >>  I don't think we need to flush immediately; set a "tlb dirty" bit
> >>  somewhere that is cleareded when we flush the tlb.
> >>  kvm_mmu_notifier_invalidate_page() can consult the bit and force a
> >>  flush if set.
> >
> >  Yep.
> >
>
> Great, i'll do it in the v3.
>
> Do we need a simple bug fix patch(which immediately flush tlbs) for
> backport first?

Oh yes.  Simple fix first, clever ideas later (which will likely need to 
be fixed anyway).


-- 
error compiling committee.c: too many arguments to function