From: Avi Kivity <avi@redhat.com>
To: Takuya Yoshikawa <yoshikawa.takuya@oss.ntt.co.jp>
Cc: mtosatti@redhat.com, laijs@cn.fujitsu.com, kvm@vger.kernel.org,
takuya.yoshikawa@gmail.com
Subject: Re: [RFC PATCH 1/2] KVM: count the number of dirty bits for each memslot
Date: Thu, 18 Nov 2010 14:54:23 +0200 [thread overview]
Message-ID: <4CE521FF.5010509@redhat.com> (raw)
In-Reply-To: <20101118141407.265ec727.yoshikawa.takuya@oss.ntt.co.jp>
On 11/18/2010 07:14 AM, Takuya Yoshikawa wrote:
> This patch introduces the counter to hold the number of dirty bits in each
> memslot. We will use this to optimize dirty logging later.
>
>
> @@ -3217,11 +3216,8 @@ int kvm_vm_ioctl_get_dirty_log(struct kvm *kvm,
>
> n = kvm_dirty_bitmap_bytes(memslot);
>
> - for (i = 0; !is_dirty&& i< n/sizeof(long); i++)
> - is_dirty = memslot->dirty_bitmap[i];
> -
This can already be an improvement.
> @@ -152,6 +152,7 @@ struct kvm_memory_slot {
> unsigned long *rmap;
> unsigned long *dirty_bitmap;
> unsigned long *dirty_bitmap_head;
> + unsigned long num_dirty_bits;
The bits themselves are not dirty; only the pages are dirty.
(+ we usually use 'nr' for 'number')
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2010-11-18 12:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-18 5:12 [RFC PATCH 0/2] KVM: dirty logging optimization Takuya Yoshikawa
2010-11-18 5:14 ` [RFC PATCH 1/2] KVM: count the number of dirty bits for each memslot Takuya Yoshikawa
2010-11-18 12:54 ` Avi Kivity [this message]
2010-11-18 13:10 ` Jan Kiszka
2010-11-18 13:14 ` Avi Kivity
2010-11-18 5:15 ` [RFC PATCH 2/2] KVM: selective write protection using dirty bitmap Takuya Yoshikawa
2010-11-18 13:06 ` Avi Kivity
2010-11-19 8:30 ` Takuya Yoshikawa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CE521FF.5010509@redhat.com \
--to=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=laijs@cn.fujitsu.com \
--cc=mtosatti@redhat.com \
--cc=takuya.yoshikawa@gmail.com \
--cc=yoshikawa.takuya@oss.ntt.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox