From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [RFC PATCH 1/2] KVM: count the number of dirty bits for each memslot Date: Thu, 18 Nov 2010 14:54:23 +0200 Message-ID: <4CE521FF.5010509@redhat.com> References: <20101118141232.d1d25679.yoshikawa.takuya@oss.ntt.co.jp> <20101118141407.265ec727.yoshikawa.takuya@oss.ntt.co.jp> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: mtosatti@redhat.com, laijs@cn.fujitsu.com, kvm@vger.kernel.org, takuya.yoshikawa@gmail.com To: Takuya Yoshikawa Return-path: Received: from mx1.redhat.com ([209.132.183.28]:38183 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756981Ab0KRMyg (ORCPT ); Thu, 18 Nov 2010 07:54:36 -0500 In-Reply-To: <20101118141407.265ec727.yoshikawa.takuya@oss.ntt.co.jp> Sender: kvm-owner@vger.kernel.org List-ID: On 11/18/2010 07:14 AM, Takuya Yoshikawa wrote: > This patch introduces the counter to hold the number of dirty bits in each > memslot. We will use this to optimize dirty logging later. > > > @@ -3217,11 +3216,8 @@ int kvm_vm_ioctl_get_dirty_log(struct kvm *kvm, > > n = kvm_dirty_bitmap_bytes(memslot); > > - for (i = 0; !is_dirty&& i< n/sizeof(long); i++) > - is_dirty = memslot->dirty_bitmap[i]; > - This can already be an improvement. > @@ -152,6 +152,7 @@ struct kvm_memory_slot { > unsigned long *rmap; > unsigned long *dirty_bitmap; > unsigned long *dirty_bitmap_head; > + unsigned long num_dirty_bits; The bits themselves are not dirty; only the pages are dirty. (+ we usually use 'nr' for 'number') -- error compiling committee.c: too many arguments to function