From: Andi Kleen <ak@linux.intel.com>
To: Avi Kivity <avi@redhat.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>, kvm@vger.kernel.org
Subject: Re: [PATCH] KVM: VMX: Fold __vmx_vcpu_run() into vmx_vcpu_run()
Date: Thu, 18 Nov 2010 16:00:01 +0100 [thread overview]
Message-ID: <4CE53F71.5010609@linux.intel.com> (raw)
In-Reply-To: <4CE538F3.7020809@redhat.com>
On 11/18/2010 3:32 PM, Avi Kivity wrote:
> On 11/18/2010 03:48 PM, Andi Kleen wrote:
>> On 11/18/2010 1:17 PM, Avi Kivity wrote:
>>> cea15c2 ("KVM: Move KVM context switch into own function") split
>>> vmx_vcpu_run()
>>> to prevent multiple copies of the context switch from being
>>> generated (causing
>>> problems due to a label). This patch folds them back together again
>>> and adds
>>> the __noclone attribute to prevent the label from being duplicated.
>>
>> That won't work on gcc versions that didn't have __noclone yet.
>> Noclone is fairly recent
>> (4.5 or 4.4)
>
> Are the gcc versions that don't have noclone susceptible to cloning?
I believe the problem can happen due to inlining already
-Andi
next prev parent reply other threads:[~2010-11-18 15:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-18 12:17 [PATCH] KVM: VMX: Fold __vmx_vcpu_run() into vmx_vcpu_run() Avi Kivity
2010-11-18 13:48 ` Andi Kleen
2010-11-18 14:32 ` Avi Kivity
2010-11-18 15:00 ` Andi Kleen [this message]
2010-11-18 15:08 ` Avi Kivity
2010-11-22 9:12 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CE53F71.5010609@linux.intel.com \
--to=ak@linux.intel.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox