From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andi Kleen Subject: Re: [PATCH] KVM: VMX: Fold __vmx_vcpu_run() into vmx_vcpu_run() Date: Thu, 18 Nov 2010 16:00:01 +0100 Message-ID: <4CE53F71.5010609@linux.intel.com> References: <1290082665-12540-1-git-send-email-avi@redhat.com> <4CE52EC7.2020106@linux.intel.com> <4CE538F3.7020809@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , kvm@vger.kernel.org To: Avi Kivity Return-path: Received: from mga11.intel.com ([192.55.52.93]:42449 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757640Ab0KRPAD (ORCPT ); Thu, 18 Nov 2010 10:00:03 -0500 In-Reply-To: <4CE538F3.7020809@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 11/18/2010 3:32 PM, Avi Kivity wrote: > On 11/18/2010 03:48 PM, Andi Kleen wrote: >> On 11/18/2010 1:17 PM, Avi Kivity wrote: >>> cea15c2 ("KVM: Move KVM context switch into own function") split >>> vmx_vcpu_run() >>> to prevent multiple copies of the context switch from being >>> generated (causing >>> problems due to a label). This patch folds them back together again >>> and adds >>> the __noclone attribute to prevent the label from being duplicated. >> >> That won't work on gcc versions that didn't have __noclone yet. >> Noclone is fairly recent >> (4.5 or 4.4) > > Are the gcc versions that don't have noclone susceptible to cloning? I believe the problem can happen due to inlining already -Andi