From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] KVM: VMX: Fold __vmx_vcpu_run() into vmx_vcpu_run() Date: Thu, 18 Nov 2010 17:08:15 +0200 Message-ID: <4CE5415F.9090807@redhat.com> References: <1290082665-12540-1-git-send-email-avi@redhat.com> <4CE52EC7.2020106@linux.intel.com> <4CE538F3.7020809@redhat.com> <4CE53F71.5010609@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , kvm@vger.kernel.org To: Andi Kleen Return-path: Received: from mx1.redhat.com ([209.132.183.28]:54432 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756378Ab0KRPIk (ORCPT ); Thu, 18 Nov 2010 10:08:40 -0500 In-Reply-To: <4CE53F71.5010609@linux.intel.com> Sender: kvm-owner@vger.kernel.org List-ID: On 11/18/2010 05:00 PM, Andi Kleen wrote: > On 11/18/2010 3:32 PM, Avi Kivity wrote: >> On 11/18/2010 03:48 PM, Andi Kleen wrote: >>> On 11/18/2010 1:17 PM, Avi Kivity wrote: >>>> cea15c2 ("KVM: Move KVM context switch into own function") split >>>> vmx_vcpu_run() >>>> to prevent multiple copies of the context switch from being >>>> generated (causing >>>> problems due to a label). This patch folds them back together >>>> again and adds >>>> the __noclone attribute to prevent the label from being duplicated. >>> >>> That won't work on gcc versions that didn't have __noclone yet. >>> Noclone is fairly recent >>> (4.5 or 4.4) >> >> Are the gcc versions that don't have noclone susceptible to cloning? > > I believe the problem can happen due to inlining already vmx_vcpu_run() cannot be inlined (it is only called via a function pointer; call site is in a different module) -- error compiling committee.c: too many arguments to function