Re: [PATCH] KVM: VMX: Fold __vmx_vcpu_run() into vmx_vcpu_run()

[Avi Kivity <avi@redhat.com>]

On 11/18/2010 05:08 PM, Avi Kivity wrote:
> On 11/18/2010 05:00 PM, Andi Kleen wrote:
>> On 11/18/2010 3:32 PM, Avi Kivity wrote:
>>> On 11/18/2010 03:48 PM, Andi Kleen wrote:
>>>> On 11/18/2010 1:17 PM, Avi Kivity wrote:
>>>>> cea15c2 ("KVM: Move KVM context switch into own function") split 
>>>>> vmx_vcpu_run()
>>>>> to prevent multiple copies of the context switch from being 
>>>>> generated (causing
>>>>> problems due to a label).  This patch folds them back together 
>>>>> again and adds
>>>>> the __noclone attribute to prevent the label from being duplicated.
>>>>
>>>> That won't work on gcc versions that didn't have __noclone yet. 
>>>> Noclone is fairly recent
>>>> (4.5 or 4.4)
>>>
>>> Are the gcc versions that don't have noclone susceptible to cloning?
>>
>> I believe the problem can happen due to inlining already
>
> vmx_vcpu_run() cannot be inlined (it is only called via a function 
> pointer; call site is in a different module)
>

Well, I've applied the patch; if it breaks again, let me know, and I'll 
revert it.

-- 
error compiling committee.c: too many arguments to function