From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: trace_printk() support in trace-cmd Date: Tue, 23 Nov 2010 12:52:01 +0200 Message-ID: <4CEB9CD1.8050002@redhat.com> References: <4CE16941.3080008@redhat.com> <1289841107.12418.602.camel@gandalf.stny.rr.com> <4CE16E64.2040909@redhat.com> <1289846036.12418.604.camel@gandalf.stny.rr.com> <4CE24CA9.9030508@redhat.com> <1289913102.12418.622.camel@gandalf.stny.rr.com> <1289920353.30543.4.camel@gandalf.stny.rr.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Cc: linux-trace-users@vger.kernel.org, KVM list To: Steven Rostedt Return-path: In-Reply-To: <1289920353.30543.4.camel@gandalf.stny.rr.com> Sender: linux-trace-users-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 11/16/2010 05:12 PM, Steven Rostedt wrote: > > > > Hmm, I'll try it out on the latest kernel. Would you be able to upload > > the trace.dat that does not work someplace that I can get it. I'd like > > to take a look at it. If you don't have a place to put it, I could give > > you access to my box, and you can scp it there. > > Hmm, I still can not reproduce. But as a workaround, here's what you can > do for now. Instead of using trace_printk() use: > > > __trace_printk(_THIS_IP_, "format", args); > > This will force the snprintf into the buffer and skips the bprintk trick > to post process at read time. I see a trace_printk() commit in trace-cmd.git. Is that related? If not, I'll work on getting a small sample of the problem. -- error compiling committee.c: too many arguments to function