From: Avi Kivity <avi@redhat.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-trace-users@vger.kernel.org, KVM list <kvm@vger.kernel.org>
Subject: Re: trace_printk() support in trace-cmd
Date: Tue, 23 Nov 2010 16:37:34 +0200 [thread overview]
Message-ID: <4CEBD1AE.7000203@redhat.com> (raw)
In-Reply-To: <1290522640.30543.306.camel@gandalf.stny.rr.com>
On 11/23/2010 04:30 PM, Steven Rostedt wrote:
> On Tue, 2010-11-23 at 13:04 +0200, Avi Kivity wrote:
> > On 11/16/2010 05:13 PM, Steven Rostedt wrote:
> > > BTW, what does /debug/tracing/printk_formats show?
> > >
> >
> > Empty.
> >
>
> So you have real trace_printk's not bprintk's?
>
What are bprintk()s?
> That is, if the format is not a const, then we fall back to
> __trace_printk(_THIS_IP_, fmt, args);
>
> And this is a different object. I have not tested these in a while, I'll
> give it a try.
>
> But if your printks are bprintks, then the bug is in the kernel, since
> that printk_formats needs to show something.
What I do is sprinkle trace_printk()s around my code and expect to see
them interspersed with enabled tracepoints in 'trace-cmd report'. Is
that not the intended behaviour?
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2010-11-23 14:37 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-15 17:09 trace_printk() support in trace-cmd Avi Kivity
2010-11-15 17:11 ` Steven Rostedt
2010-11-15 17:31 ` Avi Kivity
2010-11-15 18:33 ` Steven Rostedt
2010-11-16 9:19 ` Avi Kivity
2010-11-16 13:11 ` Steven Rostedt
2010-11-16 15:12 ` Steven Rostedt
2010-11-23 10:52 ` Avi Kivity
2010-12-12 16:10 ` Avi Kivity
2010-12-13 15:26 ` Steven Rostedt
2010-12-13 15:43 ` Avi Kivity
2010-12-13 16:28 ` Steven Rostedt
2010-12-13 17:05 ` Avi Kivity
2010-12-13 17:05 ` Avi Kivity
2010-11-16 15:13 ` Steven Rostedt
2010-11-23 11:04 ` Avi Kivity
2010-11-23 14:30 ` Steven Rostedt
2010-11-23 14:37 ` Avi Kivity [this message]
2010-11-23 15:45 ` Steven Rostedt
2010-12-12 16:35 ` Avi Kivity
2010-12-12 17:36 ` Arnaldo Carvalho de Melo
2010-12-12 17:42 ` Avi Kivity
2010-12-12 17:43 ` Arnaldo Carvalho de Melo
2010-12-12 17:47 ` Avi Kivity
2010-12-13 11:20 ` Masami Hiramatsu
2010-12-16 10:20 ` Avi Kivity
2010-12-16 13:36 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CEBD1AE.7000203@redhat.com \
--to=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-trace-users@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox