From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH kvm-unit-tests 2/4] Introduce a C++ wrapper for the kvm APIs Date: Wed, 24 Nov 2010 16:31:26 +0200 Message-ID: <4CED21BE.4000203@redhat.com> References: <1290595933-13122-1-git-send-email-avi@redhat.com> <1290595933-13122-3-git-send-email-avi@redhat.com> <50DD1E97-0ECD-41E6-B6F8-1D78AA4A4876@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , kvm@vger.kernel.org To: Alexander Graf Return-path: Received: from mx1.redhat.com ([209.132.183.28]:56456 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751376Ab0KXObc (ORCPT ); Wed, 24 Nov 2010 09:31:32 -0500 In-Reply-To: <50DD1E97-0ECD-41E6-B6F8-1D78AA4A4876@suse.de> Sender: kvm-owner@vger.kernel.org List-ID: On 11/24/2010 02:59 PM, Alexander Graf wrote: > On 24.11.2010, at 11:52, Avi Kivity wrote: > > > Introduce exception-safe objects for calling system, vm, and vcpu ioctls. > > > > Signed-off-by: Avi Kivity > > > FWIW, I still disagree with C++ and believe this code to be hardly readable. > The equivalent C code would have either no error checking or it would be a mess of error handling intermixed with bugs and a few lines which do actual work. -- error compiling committee.c: too many arguments to function