From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: [PATCH kvm-unit-tests 2/4] Introduce a C++ wrapper for the kvm APIs Date: Wed, 24 Nov 2010 08:41:26 -0600 Message-ID: <4CED2416.1040102@codemonkey.ws> References: <1290595933-13122-1-git-send-email-avi@redhat.com> <1290595933-13122-3-git-send-email-avi@redhat.com> <50DD1E97-0ECD-41E6-B6F8-1D78AA4A4876@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Avi Kivity , Marcelo Tosatti , kvm@vger.kernel.org To: Alexander Graf Return-path: Received: from mail-gx0-f174.google.com ([209.85.161.174]:64162 "EHLO mail-gx0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750894Ab0KXOl4 (ORCPT ); Wed, 24 Nov 2010 09:41:56 -0500 Received: by gxk22 with SMTP id 22so765788gxk.19 for ; Wed, 24 Nov 2010 06:41:56 -0800 (PST) In-Reply-To: <50DD1E97-0ECD-41E6-B6F8-1D78AA4A4876@suse.de> Sender: kvm-owner@vger.kernel.org List-ID: On 11/24/2010 06:59 AM, Alexander Graf wrote: > On 24.11.2010, at 11:52, Avi Kivity wrote: > > >> Introduce exception-safe objects for calling system, vm, and vcpu ioctls. >> >> Signed-off-by: Avi Kivity >> > > FWIW, I still disagree with C++ and believe this code to be hardly readable. > There's a general prettiness that well written C++ code will have over C when there's heavy object modelling. This can be subjective but for me, it's fairly significant. The fact that objects are easily created on the stack and on the heap is also pretty significant. When considering device models, we struggle today with device composition. In real hardware, the i8042 (keyboard controller) is actually implemented in the PIIX3 which is a chip that is part of the i440fx. The i440fx acts as both the memory controller and as the PCI Host controller. So you get something that looks like: class PIIX3 : public PCIDevice { private: I8042 i8042; RTC rtc; // ... }; class I440FX : public PCIHostController { I440FX(void) { this->slots[1].plug(&this->piix3); // piix3 is always in slot 1 } private: Plug slots[32]; // slot 0 is the PMC PIIX3 piix3; }; So whereas we have this very complicate machine create function that attempts to create and composite all of these devices after the fact, when written in C++, partially due to good design, but partially due to the fact that the languages forces you to think a certain way, you get a tremendous simplification. A proper C++ device model turns a vast majority of our device creation complexity into a single new I440FX. Then it's just a matter of instantiating and plugging the appropriate set of PCI devices. Of course, this can be wrapped in a factory to make it drivable via an API or config file. Another area that C++ shines is safety. C++ enables you to inject safe versions of things that you really can't do in C. For instance, the PIT has three channels but the mask to select a channel is two bits. There was a kernel exploit that found a way to trick selection of a forth channel because of a missing check. In C++, you can convert: PITChannel channnels[3]; Into: Array channels; It behaves in every other way just like a normal array. The memory is stack allocated, the type has a fixed size. The only difference is that you can overload the [] operators and implement bounds checking for array accesses. This means that as long as you use Array<>, array overflows disappear from the code base. That's a big deal. Another area C++ shines is generating metacode. Consider the ugliness around VMState. The crux of the problem is that it's not possible to write type-neutral code in C. This all gets simplified with C++. Instead of having a bunch of macros like: VMSTATE_INT8(val0, ...) VMSTATE_INT16(val1, ...) You can just have: vmstate(val0) vmstate(val1) And use type overloading to implement different behaviors. Combined with template specialization and an Array wrapper, the same thing works for arrays too. Regards, Anthony Liguori Regards, Anthony Liguori > Alex > > > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >