From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH kvm-unit-tests 2/4] Introduce a C++ wrapper for the kvm APIs Date: Wed, 24 Nov 2010 18:14:22 +0200 Message-ID: <4CED39DE.3030207@redhat.com> References: <1290595933-13122-1-git-send-email-avi@redhat.com> <1290595933-13122-3-git-send-email-avi@redhat.com> <50DD1E97-0ECD-41E6-B6F8-1D78AA4A4876@suse.de> <4CED2416.1040102@codemonkey.ws> <20101124154006.GE15111@redhat.com> <4CED344B.3030000@codemonkey.ws> <20101124161204.GF15111@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Anthony Liguori , Alexander Graf , Marcelo Tosatti , kvm@vger.kernel.org To: Gleb Natapov Return-path: Received: from mx1.redhat.com ([209.132.183.28]:6958 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751443Ab0KXQOa (ORCPT ); Wed, 24 Nov 2010 11:14:30 -0500 In-Reply-To: <20101124161204.GF15111@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 11/24/2010 06:12 PM, Gleb Natapov wrote: > > > > Why would we specify a PIIX3 device based on a configuration file? > > There is only one PIIX3 device in the world. I don't see a lot of > > need to create arbitrary types of devices. > > > Why deny this flexibility from those who need it for modelling > different HW? The various components exist and can be reused. > Besides, as I said, PIIX3 is ISA bridge and this > is what class should implement. Isn't it an ISA bridge + a few ISA devices? > We have fw_cfg on ISA bus too > which does not exits on real HW and we may want to have other > devices. We should be able to add them without changing PIIX3 > class. fw_cfg should certainly not be a member of PIIX3. -- error compiling committee.c: too many arguments to function