From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH kvm-unit-tests 2/4] Introduce a C++ wrapper for the kvm APIs Date: Wed, 24 Nov 2010 18:56:52 +0200 Message-ID: <4CED43D4.1070107@redhat.com> References: <50DD1E97-0ECD-41E6-B6F8-1D78AA4A4876@suse.de> <4CED2416.1040102@codemonkey.ws> <20101124154006.GE15111@redhat.com> <4CED344B.3030000@codemonkey.ws> <20101124161204.GF15111@redhat.com> <4CED39DE.3030207@redhat.com> <20101124162153.GA20014@redhat.com> <4CED3C88.3040501@redhat.com> <20101124162956.GB20014@redhat.com> <4CED3E4D.8050608@redhat.com> <20101124165244.GD20014@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Anthony Liguori , Alexander Graf , Marcelo Tosatti , kvm@vger.kernel.org To: Gleb Natapov Return-path: Received: from mx1.redhat.com ([209.132.183.28]:29607 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755463Ab0KXQ47 (ORCPT ); Wed, 24 Nov 2010 11:56:59 -0500 In-Reply-To: <20101124165244.GD20014@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 11/24/2010 06:52 PM, Gleb Natapov wrote: > > Plus some magic glue. You can't say it is an ISA bridge. It's > > exactly what its spec says it is. > > > First thing my spec says is "Bridge Between the PCI Bus and ISA Bus" It's the first item in a list of features. Be serious. > > >> > > >> I couldn't find it in the PIIX3 spec. > > >> > > >I couldn't find it in _any_ spec. Should we get rid of it? > > > > Or write a spec. > > > It will not make it part of any existing system. > That is not a requirement. We have virtio as well. When we do have a spec for something, we should implement it as the spec says, not according to our ideas of how it should be. -- error compiling committee.c: too many arguments to function