From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH kvm-unit-tests 2/4] Introduce a C++ wrapper for the kvm APIs Date: Wed, 24 Nov 2010 19:01:00 +0200 Message-ID: <4CED44CC.6080604@redhat.com> References: <1290595933-13122-1-git-send-email-avi@redhat.com> <1290595933-13122-3-git-send-email-avi@redhat.com> <50DD1E97-0ECD-41E6-B6F8-1D78AA4A4876@suse.de> <4CED2416.1040102@codemonkey.ws> <20101124154006.GE15111@redhat.com> <4CED344B.3030000@codemonkey.ws> <4CED3FE6.50900@redhat.com> <4CED41A0.8060003@redhat.com> <20101124165502.GE20014@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Jes Sorensen , Anthony Liguori , Alexander Graf , Marcelo Tosatti , kvm@vger.kernel.org To: Gleb Natapov Return-path: Received: from mx1.redhat.com ([209.132.183.28]:8702 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755795Ab0KXRBO (ORCPT ); Wed, 24 Nov 2010 12:01:14 -0500 In-Reply-To: <20101124165502.GE20014@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 11/24/2010 06:55 PM, Gleb Natapov wrote: > > > > > >What you did above is making the exact same mistake as is done with the > > >current i440fx.c code. > > > > If a real life 440fx has an i8042, then an emulated 440fx should > > have an emulated i8042. It's not complicated. > > > Correct. But it can be achieved by making 440fx a class that includes > other classes or by building it from different classes linked through > common interfaces. Both are fine, and not in conflict with the example that started this. If the i8042 is completely stock, we write class i440fx { private: i8042 kbc; } (or the C equivalent) If it's not completely stock, we substitute some subclass that takes care of the differences. -- error compiling committee.c: too many arguments to function