Re: [PATCH 1/2] Add "broadcast" option for mce command.

[Jin Dongming <jin.dongming@np.css.fujitsu.com>]

Hi, Huang-san

(2010/11/25 10:33), Huang Ying wrote:
> On Thu, 2010-11-25 at 09:19 +0800, Jin Dongming wrote:
> [...]
> 
>> --- a/hmp-commands.hx
>> +++ b/hmp-commands.hx
>> @@ -1053,9 +1053,15 @@ ETEXI
>>  
>>      {
>>          .name       = "mce",
>> +#if defined(KVM_CAP_MCE)
>> +        .args_type  = "cpu_index:i,bank:i,status:l,mcg_status:l,addr:l,misc:l,broadcast:s?",
>> +        .params     = "cpu bank status mcgstatus addr misc [broadcast|b]",
>> +        .help       = "inject a MCE on the given CPU [and broadcast to other CPUs]",
>> +#else
>>          .args_type  = "cpu_index:i,bank:i,status:l,mcg_status:l,addr:l,misc:l",
>>          .params     = "cpu bank status mcgstatus addr misc",
>>          .help       = "inject a MCE on the given CPU",
>> +#endif
> 
> Broadcast can not be used by QEMU-TCG?
I must say sorry, I don't know much about QEMU-TCG.

Because broadcast option used kvm_mce_broadcast_rest() in KVM_CAP_MCE,
so if KVM_CAP_MCE is disabled, broadcast option could not work well.

And I don't know how mce command is used in other virtual machine
without KVM module, so I add ifdef to make sure this patch does not give
any impact to other virtual machine without KVM module.

Best Regards,
Jin Dongming
> 
> [...]
> 
> Best Regards,
> Huang Ying
> 
> 
> 
>