From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jin Dongming <jin.dongming@np.css.fujitsu.com>
Subject: Re: [PATCH 1/2] Add "broadcast" option for mce command.
Date: Thu, 25 Nov 2010 13:25:59 +0900
Message-ID: <4CEDE557.6010504@np.css.fujitsu.com>
References: <4CEDB9A2.1030606@np.css.fujitsu.com> <1290648818.2903.182.camel@yhuang-dev>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Cc: Avi Kivity <avi@redhat.com>, Marcelo Tosatti <mtosatti@redhat.com>,
	Andi Kleen <andi@firstfloor.org>,
	Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>,
	Dean Nelson <dnelson@redhat.com>,
	KVM list <kvm@vger.kernel.org>
To: Huang Ying <ying.huang@intel.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from fgwmail7.fujitsu.co.jp ([192.51.44.37]:44474 "EHLO
	fgwmail7.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751343Ab0KYEX4 (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 24 Nov 2010 23:23:56 -0500
Received: from m6.gw.fujitsu.co.jp ([10.0.50.76])
	by fgwmail7.fujitsu.co.jp (Fujitsu Gateway) with ESMTP id oAP4NrFx031924
	for <kvm@vger.kernel.org> (envelope-from jin.dongming@np.css.fujitsu.com);
	Thu, 25 Nov 2010 13:23:53 +0900
Received: from smail (m6 [127.0.0.1])
	by outgoing.m6.gw.fujitsu.co.jp (Postfix) with ESMTP id 31A1945DE51
	for <kvm@vger.kernel.org>; Thu, 25 Nov 2010 13:23:53 +0900 (JST)
Received: from s6.gw.fujitsu.co.jp (s6.gw.fujitsu.co.jp [10.0.50.96])
	by m6.gw.fujitsu.co.jp (Postfix) with ESMTP id 154FE45DE4F
	for <kvm@vger.kernel.org>; Thu, 25 Nov 2010 13:23:53 +0900 (JST)
Received: from s6.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1])
	by s6.gw.fujitsu.co.jp (Postfix) with ESMTP id E365D1DB8016
	for <kvm@vger.kernel.org>; Thu, 25 Nov 2010 13:23:52 +0900 (JST)
Received: from m000.s.css.fujitsu.com (m000.s.css.fujitsu.com [10.23.4.38])
	by s6.gw.fujitsu.co.jp (Postfix) with ESMTP id A66C61DB8014
	for <kvm@vger.kernel.org>; Thu, 25 Nov 2010 13:23:52 +0900 (JST)
In-Reply-To: <1290648818.2903.182.camel@yhuang-dev>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Hi, Huang-san

(2010/11/25 10:33), Huang Ying wrote:
> On Thu, 2010-11-25 at 09:19 +0800, Jin Dongming wrote:
> [...]
> 
>> --- a/hmp-commands.hx
>> +++ b/hmp-commands.hx
>> @@ -1053,9 +1053,15 @@ ETEXI
>>  
>>      {
>>          .name       = "mce",
>> +#if defined(KVM_CAP_MCE)
>> +        .args_type  = "cpu_index:i,bank:i,status:l,mcg_status:l,addr:l,misc:l,broadcast:s?",
>> +        .params     = "cpu bank status mcgstatus addr misc [broadcast|b]",
>> +        .help       = "inject a MCE on the given CPU [and broadcast to other CPUs]",
>> +#else
>>          .args_type  = "cpu_index:i,bank:i,status:l,mcg_status:l,addr:l,misc:l",
>>          .params     = "cpu bank status mcgstatus addr misc",
>>          .help       = "inject a MCE on the given CPU",
>> +#endif
> 
> Broadcast can not be used by QEMU-TCG?
I must say sorry, I don't know much about QEMU-TCG.

Because broadcast option used kvm_mce_broadcast_rest() in KVM_CAP_MCE,
so if KVM_CAP_MCE is disabled, broadcast option could not work well.

And I don't know how mce command is used in other virtual machine
without KVM module, so I add ifdef to make sure this patch does not give
any impact to other virtual machine without KVM module.

Best Regards,
Jin Dongming
> 
> [...]
> 
> Best Regards,
> Huang Ying
> 
> 
> 
>