From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jin Dongming Subject: Re: [PATCH] Add function for clearing the requested VCPUs' mce registers. Date: Thu, 25 Nov 2010 17:43:08 +0900 Message-ID: <4CEE219C.6070901@np.css.fujitsu.com> References: <4CEDB86C.2050402@np.css.fujitsu.com> <1290648466.2903.179.camel@yhuang-dev> <4CEDF45A.1000901@np.css.fujitsu.com> <1290663884.2903.309.camel@yhuang-dev> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: Avi Kivity , Marcelo Tosatti , Andi Kleen , Hidetoshi Seto , KVM list To: Huang Ying Return-path: Received: from fgwmail5.fujitsu.co.jp ([192.51.44.35]:37898 "EHLO fgwmail5.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751374Ab0KYIlE (ORCPT ); Thu, 25 Nov 2010 03:41:04 -0500 Received: from m1.gw.fujitsu.co.jp ([10.0.50.71]) by fgwmail5.fujitsu.co.jp (Fujitsu Gateway) with ESMTP id oAP8f1C2011694 for (envelope-from jin.dongming@np.css.fujitsu.com); Thu, 25 Nov 2010 17:41:01 +0900 Received: from smail (m1 [127.0.0.1]) by outgoing.m1.gw.fujitsu.co.jp (Postfix) with ESMTP id 34B8F45DE59 for ; Thu, 25 Nov 2010 17:41:01 +0900 (JST) Received: from s1.gw.fujitsu.co.jp (s1.gw.fujitsu.co.jp [10.0.50.91]) by m1.gw.fujitsu.co.jp (Postfix) with ESMTP id 1C60D45DE56 for ; Thu, 25 Nov 2010 17:41:01 +0900 (JST) Received: from s1.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1]) by s1.gw.fujitsu.co.jp (Postfix) with ESMTP id 0943AE08001 for ; Thu, 25 Nov 2010 17:41:01 +0900 (JST) Received: from m002.s.css.fujitsu.com (m002.s.css.fujitsu.com [10.23.4.32]) by s1.gw.fujitsu.co.jp (Postfix) with ESMTP id CA05CE38002 for ; Thu, 25 Nov 2010 17:41:00 +0900 (JST) In-Reply-To: <1290663884.2903.309.camel@yhuang-dev> Sender: kvm-owner@vger.kernel.org List-ID: Hi, Huang-san (2010/11/25 14:44), Huang Ying wrote: > On Thu, 2010-11-25 at 13:30 +0800, Jin Dongming wrote: >> Hi, Huang-san >> >> (2010/11/25 10:27), Huang Ying wrote: >>> Hi, Dongming, >>> >>> On Thu, 2010-11-25 at 09:14 +0800, Jin Dongming wrote: >>>> In some case of mce test, the injected data can be remained >>>> in the registers and ca affect to the result of following test cases. >>>> So add codes for clearing mce registers of given VCPU. >>>> >>>> mce registers of give VCPU could be cleared from kernel by calling >>>> the function in this patch. What need to be paid attention is that >>>> the status and mcg_status of mce must be set with 0. If not, mce >>>> registers will not be cleared. >>> >>> Why do you need this? To use "mce=3" in guest Linux MCE testing? >> When I set fake_panic==1 on Guest OS and tested mce via qemu-monitor, >> I got the wrong result sometimes. The reason why I got the wrong result >> was that mce registers were not cleared. So I made this patch. > > This can be done in QEMU via KVM_SET_MSRS too. Yes, it could be done in Guest OS with APL. So I will cancel this patch. Best Regards, Jin Dongming > >>> If it is, why not use full reboot? MCE registers are not cleared in real >>> machine too. And it is not so pain to reboot the guest. >> Though we know that mce registers could be cleared by rebooting the Guest >> Machine and the reboot of Guest Machine could save much more time than >> the reboot of Host Machine, it is still slower than setting >> fake_panic==1 to mce test. > > Best Regards, > Huang Ying > > > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > >