From: Gerd Hoffmann <kraxel@redhat.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: qemu-devel@nongnu.org, kvm <kvm@vger.kernel.org>,
Matthew Garrett <mjg59@srcf.ucam.org>,
Adam Jackson <ajax@redhat.com>,
Glauber de Oliveira Costa <gcosta@redhat.com>
Subject: Re: PATCH: QEMU support for UHCI suspend / remote wake up
Date: Thu, 25 Nov 2010 17:15:33 +0100 [thread overview]
Message-ID: <4CEE8BA5.7020900@redhat.com> (raw)
In-Reply-To: <20101125153455.GA4097@amt.cnet>
Hi,
> + dev->info->remote_wakeup_cb = uhci_event;
> diff --git a/hw/usb.h b/hw/usb.h
> index 00d2802..16de1c9 100644
> --- a/hw/usb.h
> +++ b/hw/usb.h
> @@ -189,6 +189,11 @@ struct USBDeviceInfo {
> */
> int (*handle_data)(USBDevice *dev, USBPacket *p);
>
> + /*
> + * Process remote wakeup request.
> + */
> + void (*remote_wakeup_cb)(USBDevice *dev);
> +
No way. DeviceInfo holds informations about the device
*implementation*. Multiple instances will share that, placing runtime
data there is just plain wrong.
Also this is a callback from the usb device to the usb host adapter, not
the other way around. I'd suggest to create a USBBusOps for host
adapter callbacks and and stick it into USBBus.
cheers,
Gerd
next prev parent reply other threads:[~2010-11-25 16:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-25 15:34 PATCH: QEMU support for UHCI suspend / remote wake up Marcelo Tosatti
2010-11-25 16:15 ` Gerd Hoffmann [this message]
2010-11-25 17:04 ` [patch 0/2] USB UHCI global suspend / remote wakeup Marcelo Tosatti
2010-11-25 17:04 ` [patch 1/2] add USBBusOps to USBBus Marcelo Tosatti
2010-11-25 17:04 ` [patch 2/2] support for UHCI suspend / remote wake up Marcelo Tosatti
2010-12-01 15:12 ` Gerd Hoffmann
2010-12-01 16:58 ` Marcelo Tosatti
2010-12-01 17:17 ` Gerd Hoffmann
2010-11-26 0:38 ` [patch 0/2] USB UHCI global suspend / remote wakeup Paul Brook
2010-11-26 2:15 ` [Qemu-devel] " Marcelo Tosatti
2010-11-26 8:49 ` Gerd Hoffmann
2010-11-26 12:09 ` Paul Brook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CEE8BA5.7020900@redhat.com \
--to=kraxel@redhat.com \
--cc=ajax@redhat.com \
--cc=gcosta@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
--cc=mtosatti@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox