Re: [PATCH kvm-unit-tests 2/4] Introduce a C++ wrapper for the kvm APIs

Avi Kivity
2010-11-24T16:33:24Z

On 11/24/2010 06:29 PM, Gleb Natapov wrote:
> >
> > >> >Besides, as I said, PIIX3 is ISA bridge and this
> > >> >is what class should implement.
> > >>
> > >> Isn't it an ISA bridge + a few ISA devices?
> > >>
> > >Why? Because they happen to be on the same silicon? So then in SoC
> > >all devices are in cpu?
> >
> > PIIX3 is what the PIIX3 spec says it is. We decompose it into the
> > PIIX3 ISA bridge, real time clock, etc. Some of these components
> > are standardized and can be used stand-alone.
> >
> So PIIX3 is just a packaging of mostly independent components for cost
> and space cutting. Just like SoC.

Plus some magic glue. You can't say it is an ISA bridge. It's exactly
what its spec says it is.

> > >> >We have fw_cfg on ISA bus too
> > >> >which does not exits on real HW and we may want to have other
> > >> >devices. We should be able to add them without changing PIIX3
> > >> >class.
> > >>
> > >> fw_cfg should certainly not be a member of PIIX3.
> > >>
> > >It is really not much different from others.
> >
> > I couldn't find it in the PIIX3 spec.
> >
> I couldn't find it in _any_ spec. Should we get rid of it?

Or write a spec.

--
error compiling committee.c: too many arguments to function