Re: [PATCH kvm-unit-tests 2/4] Introduce a C++ wrapper for the kvm APIs

Avi Kivity
2010-11-24T14:53:19Z

On 11/24/2010 04:45 PM, Anthony Liguori wrote:
>> What would the object do besides adding tons of accessors?
>
>
> I would think that you'd have a single object that represented the
> full CPU state and then you'd have methods that allowed individual
> groups to be refreshed.
>
> Something like:
>
> struct x86_vcpu : public vcpu
> {
> uint64_t eax;
> uint64_t ebx;
> uint64_t ecx;
> //...
>
> void get_gps(void);
> void put_gps(void);
> void get_sregs(void);
> void put_sregs(void);
>
> std::string repr(void);
> };
>
> I'm not of the opinion that all members need getters and setters. I
> think it's perfectly fine to have public variables if the reads and
> writes don't have side effects.

I see. Well that belongs elsewhere, this is intended as a thin wrapper
that doesn't allows you to exercise the API directly. I don't want
things to happen automatically here, this is for a test framework.

--
error compiling committee.c: too many arguments to function