Re: [PATCH kvm-unit-tests 2/4] Introduce a C++ wrapper for the kvm APIs

Avi Kivity
2010-11-24T16:56:59Z

On 11/24/2010 06:52 PM, Gleb Natapov wrote:
> > Plus some magic glue. You can't say it is an ISA bridge. It's
> > exactly what its spec says it is.
> >
> First thing my spec says is "Bridge Between the PCI Bus and ISA Bus"

It's the first item in a list of features. Be serious.

> > >>
> > >> I couldn't find it in the PIIX3 spec.
> > >>
> > >I couldn't find it in _any_ spec. Should we get rid of it?
> >
> > Or write a spec.
> >
> It will not make it part of any existing system.
>

That is not a requirement. We have virtio as well.

When we do have a spec for something, we should implement it as the spec
says, not according to our ideas of how it should be.

--
error compiling committee.c: too many arguments to function