From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: [Qemu-devel] [PATCH 00/21] Kemari for KVM 0.2 Date: Mon, 29 Nov 2010 11:33:53 -0600 Message-ID: <4CF3E401.2000801@codemonkey.ws> References: <1290665220-26478-1-git-send-email-tamura.yoshiaki@lab.ntt.co.jp> <201011291653.42595.paul@codesourcery.com> <4CF3DD61.2010102@codemonkey.ws> <201011291718.42500.paul@codesourcery.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: qemu-devel@nongnu.org, ohmura.kei@lab.ntt.co.jp, mtosatti@redhat.com, stefanha@linux.vnet.ibm.com, kvm@vger.kernel.org, Stefan Hajnoczi , dlaor@redhat.com, Yoshiaki Tamura , ananth@in.ibm.com, Blue Swirl , aliguori@us.ibm.com, vatsa@linux.vnet.ibm.com, psuriset@linux.vnet.ibm.com, avi@redhat.com To: Paul Brook Return-path: Received: from mail-vw0-f46.google.com ([209.85.212.46]:49829 "EHLO mail-vw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751049Ab0K2Rd7 (ORCPT ); Mon, 29 Nov 2010 12:33:59 -0500 Received: by vws4 with SMTP id 4so5086vws.19 for ; Mon, 29 Nov 2010 09:33:58 -0800 (PST) In-Reply-To: <201011291718.42500.paul@codesourcery.com> Sender: kvm-owner@vger.kernel.org List-ID: On 11/29/2010 11:18 AM, Paul Brook wrote: >> On 11/29/2010 10:53 AM, Paul Brook wrote: >> >>>>> Is this a fair summary: any device that supports live migration workw >>>>> under Kemari? >>>>> >>>> It might be fair summary but practically we barely have live migration >>>> working w/o Kemari. In addition, last I checked Kemari needs additional >>>> hooks and it will be too hard to keep that out of tree until all devices >>>> get it. >>>> >>> That's not what I've been hearing earlier in this thread. >>> The responses from Yoshi indicate that Stefan's summary is correct. i.e. >>> the current Kemari implementation may require per-device hooks, but >>> that's a bug and should be fixed before merging. >>> >> It's actually really important that Kemari make use of an intermediate >> layer such that the hooks can distinguish between a device access and a >> recursive access. >> > I'm failing to understand how this is anything other than running sed over > block/*.c (or hw/*.c, depending whether you choose to rename the internal or > external API). > You're right, it's not a big deal, and requiring everything in hw use the new interface is not a bad idea. If a device doesn't work with Kemari, that's okay as long as the non-Kemari case is essentially a nop. Regards, Anthony Liguori > Paul >