From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rik van Riel Subject: Re: [RFC PATCH 1/3] kvm: keep track of which task is running a KVM vcpu Date: Fri, 03 Dec 2010 09:50:14 -0500 Message-ID: <4CF903A6.5050209@redhat.com> References: <20101202144129.4357fe00@annuminas.surriel.com> <20101202144324.4a79263b@annuminas.surriel.com> <20101203011810.GV10050@sequoia.sous-sol.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Avi Kiviti , Srivatsa Vaddagiri , Peter Zijlstra , Ingo Molnar , Anthony Liguori To: Chris Wright Return-path: In-Reply-To: <20101203011810.GV10050@sequoia.sous-sol.org> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 12/02/2010 08:18 PM, Chris Wright wrote: > * Rik van Riel (riel@redhat.com) wrote: >> Keep track of which task is running a KVM vcpu. This helps us >> figure out later what task to wake up if we want to boost a >> vcpu that got preempted. >> >> Unfortunately there are no guarantees that the same task >> always keeps the same vcpu, so we can only track the task >> across a single "run" of the vcpu. > > So shouldn't it confine to KVM_RUN? The other vcpu_load callers aren't > always a vcpu in a useful runnable state. Yeah, probably. If you want I can move the setting of vcpu->task to kvm_vcpu_ioctl. -- All rights reversed