From: Avi Kivity <avi@redhat.com>
To: David Sharp <dhsharp@google.com>
Cc: rostedt@goodmis.org, linux-kernel@vger.kernel.org,
mrubin@google.com, kvm-devel <kvm@vger.kernel.org>
Subject: Re: [PATCH 07/15] ftrace: fix event alignment: kvm:kvm_hv_hypercall
Date: Sat, 04 Dec 2010 10:11:23 +0200 [thread overview]
Message-ID: <4CF9F7AB.8050802@redhat.com> (raw)
In-Reply-To: <1291421609-14665-8-git-send-email-dhsharp@google.com>
On 12/04/2010 02:13 AM, David Sharp wrote:
> Signed-off-by: David Sharp<dhsharp@google.com>
> ---
> arch/x86/kvm/trace.h | 8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/x86/kvm/trace.h b/arch/x86/kvm/trace.h
> index a6544b8..ab41fb0 100644
> --- a/arch/x86/kvm/trace.h
> +++ b/arch/x86/kvm/trace.h
> @@ -62,21 +62,21 @@ TRACE_EVENT(kvm_hv_hypercall,
> TP_ARGS(code, fast, rep_cnt, rep_idx, ingpa, outgpa),
>
> TP_STRUCT__entry(
> - __field( __u16, code )
> - __field( bool, fast )
> __field( __u16, rep_cnt )
> __field( __u16, rep_idx )
> __field( __u64, ingpa )
> __field( __u64, outgpa )
> + __field( __u16, code )
> + __field( bool, fast )
> ),
>
Looks like a pessimisation.
Before: 24 bytes
After: 32 bytes
(on a 64-bit machine, assuming no packing)
--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.
next parent reply other threads:[~2010-12-04 8:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1291421609-14665-1-git-send-email-dhsharp@google.com>
[not found] ` <1291421609-14665-8-git-send-email-dhsharp@google.com>
2010-12-04 8:11 ` Avi Kivity [this message]
2010-12-06 20:38 ` [PATCH 07/15] ftrace: fix event alignment: kvm:kvm_hv_hypercall David Sharp
2010-12-07 9:22 ` Avi Kivity
2010-12-07 21:16 ` David Sharp
2010-12-08 9:18 ` Avi Kivity
2011-03-08 23:55 ` Steven Rostedt
2011-03-09 8:50 ` Avi Kivity
2011-03-09 12:54 ` Steven Rostedt
2011-03-09 13:01 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CF9F7AB.8050802@redhat.com \
--to=avi@redhat.com \
--cc=dhsharp@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mrubin@google.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox