From: Paolo Bonzini <pbonzini@redhat.com>
To: Glauber Costa <glommer@redhat.com>
Cc: kvm@vger.kernel.org, qemu-devel@nongnu.org, avi@redhat.com,
mtosatti@redhat.com
Subject: Re: [PATCH 2/2] Do not register kvmclock savevm section if kvmclock is disabled.
Date: Sat, 04 Dec 2010 14:41:15 +0100 [thread overview]
Message-ID: <4CFA44FB.8000200@redhat.com> (raw)
In-Reply-To: <1291373374-10296-3-git-send-email-glommer@redhat.com>
On 12/03/2010 11:49 AM, Glauber Costa wrote:
> +/* This has to happen after vcpu setup*/
> +void kvmclock_register_savevm(void)
> +{
> +#ifdef KVM_CAP_ADJUST_CLOCK
> + if (kvmclock_enabled&& kvm_check_extension(kvm_state, KVM_CAP_ADJUST_CLOCK)) {
> + printf("registering kvmclock savevm section\n");
> + vmstate_register(NULL, 0,&vmstate_kvmclock,&kvmclock_data);
> + }
> +#endif
> +}
> +
You should use a state change notifier for patch 1. Even better, if you
put this patch first adding the state change notifier will be very clean.
Paolo
prev parent reply other threads:[~2010-12-04 13:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-03 10:49 [PATCH 0/2] Fix savevm odness related to kvmclock Glauber Costa
2010-12-03 10:49 ` [PATCH 1/2] make kvmclock value idempotent for stopped machine Glauber Costa
2010-12-03 10:49 ` [PATCH 2/2] Do not register kvmclock savevm section if kvmclock is disabled Glauber Costa
2010-12-04 13:39 ` Paolo Bonzini
2010-12-04 13:41 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CFA44FB.8000200@redhat.com \
--to=pbonzini@redhat.com \
--cc=avi@redhat.com \
--cc=glommer@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox