From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH 2/2] Do not register kvmclock savevm section if kvmclock
 is disabled.
Date: Sat, 04 Dec 2010 14:41:15 +0100
Message-ID: <4CFA44FB.8000200@redhat.com>
References: <1291373374-10296-1-git-send-email-glommer@redhat.com> <1291373374-10296-3-git-send-email-glommer@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: kvm@vger.kernel.org, qemu-devel@nongnu.org, avi@redhat.com,
	mtosatti@redhat.com
To: Glauber Costa <glommer@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mail-bw0-f46.google.com ([209.85.214.46]:64590 "EHLO
	mail-bw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1755106Ab0LDNlO (ORCPT <rfc822;kvm@vger.kernel.org>);
	Sat, 4 Dec 2010 08:41:14 -0500
Received: by bwz15 with SMTP id 15so9211924bwz.19
        for <kvm@vger.kernel.org>; Sat, 04 Dec 2010 05:41:13 -0800 (PST)
In-Reply-To: <1291373374-10296-3-git-send-email-glommer@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 12/03/2010 11:49 AM, Glauber Costa wrote:
> +/* This has to happen after vcpu setup*/
> +void kvmclock_register_savevm(void)
> +{
> +#ifdef KVM_CAP_ADJUST_CLOCK
> +    if (kvmclock_enabled&&  kvm_check_extension(kvm_state, KVM_CAP_ADJUST_CLOCK)) {
> +        printf("registering kvmclock savevm section\n");
> +        vmstate_register(NULL, 0,&vmstate_kvmclock,&kvmclock_data);
> +    }
> +#endif
> +}
> +

You should use a state change notifier for patch 1.  Even better, if you 
put this patch first adding the state change notifier will be very clean.

Paolo