From mboxrd@z Thu Jan  1 00:00:00 1970
From: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
Subject: Re: [PATCH 2/2 rebased] KVM: MMU: Introduce a helper to access lpage_info
Date: Mon, 06 Dec 2010 14:37:26 +0800
Message-ID: <4CFC84A6.4060006@cn.fujitsu.com>
References: <20101206011133.e5487868.takuya.yoshikawa@gmail.com> <20101206011354.1321d3fa.takuya.yoshikawa@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Cc: avi@redhat.com, mtosatti@redhat.com, kvm@vger.kernel.org,
	yoshikawa.takuya@oss.ntt.co.jp
To: Takuya Yoshikawa <takuya.yoshikawa@gmail.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from cn.fujitsu.com ([222.73.24.84]:53297 "EHLO song.cn.fujitsu.com"
	rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP
	id S1751260Ab0LFGcr (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 6 Dec 2010 01:32:47 -0500
In-Reply-To: <20101206011354.1321d3fa.takuya.yoshikawa@gmail.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 12/06/2010 12:13 AM, Takuya Yoshikawa wrote:
> From: Takuya Yoshikawa <yoshikawa.takuya@oss.ntt.co.jp>
> 
> Index calculation to access lpage_info appears three times.
> A helper is worthwhile.
> 

Why not get lpage_info instead of index in the helper?